Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add character rarity to filter options in Characters page and Allowed Characters for Artifacts #1357

Merged
merged 7 commits into from
Dec 3, 2023
Merged

Add character rarity to filter options in Characters page and Allowed Characters for Artifacts #1357

merged 7 commits into from
Dec 3, 2023

Conversation

liaojh1998
Copy link
Contributor

@liaojh1998 liaojh1998 commented Dec 3, 2023 •
edited
Loading

Describe your changes

  • Resolves Add character rarity to filter options #1260.
  • Separated RarityToggle into WeaponRarityToggle and CharacterRarityToggle.
  • Reduced width of all toggles to '6em' to fit all filter toggles in 1 line.
  • Added filtering to Allowed Characters for Equipped Artifacts Configurations.

Note: this is not added to the "Add Characters" on the Character page because of the cluttering:
character_selection_rarity_filter

Testing/validation

  • Reduced width of all toggles to '6em' to fit all filter toggles in 1 line:
    image
  • Added filtering to Allowed Characters for Equipped Artifacts Configurations:
    image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023 •
edited
Loading

[sr-frontend] [Sun Dec 3 00:08:14 UTC 2023] - Building version

[frontend] [Sun Dec 3 00:08:19 UTC 2023] - Building version

[gi-frontend] [Sun Dec 3 00:08:48 UTC 2023] - Building version

[sr-frontend] [Sun Dec 3 00:09:22 UTC 2023] - Deployed 0553032 to https://genshin-optimizer-prs.github.io/pr/1357/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun Dec 3 00:10:27 UTC 2023] - Deployed 0553032 to https://genshin-optimizer-prs.github.io/pr/1357/frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Sun Dec 3 00:11:49 UTC 2023] - Deployed 0553032 to https://genshin-optimizer-prs.github.io/pr/1357/gi-frontend (Takes 3-5 minutes after this completes to be available)

frzyc
frzyc reviewed Dec 3, 2023
View reviewed changes
libs/consts/src/character.ts Outdated Show resolved Hide resolved
frzyc
frzyc requested changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you need to run nx format write to resolve format issues.

@liaojh1998
Copy link
Contributor Author

Ran yarn run nx format:write --base=HEAD~4 and fixed the formatting. Thanks for checking!

@liaojh1998 liaojh1998 requested a review from frzyc December 3, 2023 02:57
@frzyc frzyc merged commit 5bf1caf into frzyc:master Dec 3, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzyc frzyc frzyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add character rarity to filter options
2 participants
@liaojh1998 @frzyc