Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream formula- and pando-related changes #1235

Merged
merged 30 commits into from
Jul 18, 2023
Merged

Upstream formula- and pando-related changes #1235

merged 30 commits into from
Jul 18, 2023

Conversation

lantua
Copy link
Collaborator

@lantua lantua commented Jul 13, 2023 •
edited
Loading

In gi-formula,

  • Rename Data -> TagMap NodeEntries
  • Update conditional entry APIs
  • Add DebugCalculator

In pando,

  • Rename several Tag-related classes
  • Use assertUnreachable from util
  • Refactor common Read operation into TypedRead
  • Fix a typing issue where [] is implicitly converted to any[] in some downstream modules

lantua added 27 commits July 1, 2023 03:43
@lantua
Override nodes for dynTag in detach
56bea2c
@lantua
- Add optimization docs
669236b 
- Add test cases
- Minor refactoring
@lantua
Improve Node generic tracking
8866166
@lantua
Daily dose of linter god's blood sacrifice
6e80a1a
@lantua
Merge branch 'master' into formula
5fff00c
@lantua
Read.accu => Read.ex
fca4b6d
@lantua
type fix
2d2fa97
@lantua
- Implement lookup for compile
7c9ec09 
- Add `compile` tests
- Minor refactoring
@lantua
Data -> TaggedFormula
efcb9c9
@lantua
The Great Renaming
60d1db5 
- Add some comments
- Remove `compileTagMapEntries`
- `CompiledTagMapKeys` -> `RawTagMapKeys`
- `CompiledTagMapValues` -> `RawTagMapValues`
- `RawTagMapEntries` -> `TagMapEntries`
- `TaggedFormula`-> `TagMapNodeEntry`
- `TaggedFormulas`-> `TagMapNodeEntries`
@lantua
- Update Read._withAll
8523b6c 
- Update `allCustoms`
@lantua
Add scaffolding for sr-formula
a12aa5c
@lantua
- Update TagMapNodeEntry and TagMapNodeEntries
044ba2d 
- Add `TypedRead`
@lantua
lint
bf80516
@lantua
- Simplify TypedRead
8a3b3c3 
- Add `Read.src` for `gi-formula`
- Use `'unique'` for `undefined` accumulator in `TypedRead`
@lantua
Readjust Read.ex and Read.accu
9ce4a71
@lantua
- Update allBoolConditional API
1ae2256 
- Minor refactoring
@lantua
- Add printEntry
d94e850 
- Minor refactoring
- Minor bug fix
- lint
@lantua
Override Read.toString for gi-formula
cb2982e
@lantua
Merge branch 'master' into formula
661a993
@lantua
- lint
eed5914 
- cache
@lantua
- Add DebugCalculator for gi-formula
9f32e55 
- Add debug attachment to `Calculator`
- Regularize `Calculator.computeMeta`
- Add `tagStr` to `gi-formula`
- Remove `assertUnreachable` from `pando`
@lantua
- Update Calculator function argument types
726ef49 
- Update debug string printing
@lantua
Stop using external util
8f971c2
@lantua
Minor refactoring
bd420c8
@lantua
linting is a lie
a88b1c7
@lantua
Merge branch 'master' into formula
2b4d783
@lantua lantua marked this pull request as ready for review July 15, 2023 18:58
@nguyentvan7
Copy link
Collaborator

Can we get a small description please? ty :)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023 •
edited
Loading

[Tue Jul 18 04:23:54 UTC 2023] - Deleted deployment

@lantua lantua merged commit 51225b0 into master Jul 18, 2023
4 checks passed
@lantua lantua deleted the formula branch July 18, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyentvan7 nguyentvan7 nguyentvan7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantua @nguyentvan7