Fix effects active w/o fulfilled conditions, correct Jean's and Amber's C2 and C1 opt nodes, KQM Multi-Opt link. #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 272b906.
…T/genshin-optimizer into you-thought-i-was-done!!
This reverts commit 0f6086c.
PolomoPT
changed the title
PolomoPT
changed the title
frzyc
reviewed
Jul 4, 2023
eeeqeee
previously requested changes
Jul 4, 2023
PolomoPT
force-pushed
the
you-thought-i-was-done!!
branch
from
cc4a2b6
to
a8dd511
Compare
nguyentvan7
approved these changes
Jul 21, 2023
nguyentvan7
reviewed
Jul 21, 2023
nguyentvan7
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects being active when they shouldn't (constellation or ascension requirements not met)
Plus I removed some opt nodes from Jean because they're not scaling. And I changed Amber's things in a way that breaks multi-opts but is needed
And I'm taking the opportunity to update the KQM link thing I wanted to do.