feat(data-table): Add resizing feature for columns #785
Conversation
| } | ||
|
|
||
| resizeCol(e) { | ||
| const targetCol = e.path[0]; |
There was a problem hiding this comment.
replace it with composedPath. or do a check to see if e.path exists if not use composedPath
There was a problem hiding this comment.
fixed
| @@ -1158,10 +1205,19 @@ export class DataTable { | |||
| } | |||
| ></fw-checkbox> | |||
| )} | |||
| {this.colResize && ( | |||
There was a problem hiding this comment.
can you move this to a function/variable which return this JSX element and use it in other places. I see some repetition of this code.
There was a problem hiding this comment.
fixed
| @Watch('colResize') | ||
| handleColResize() { | ||
| setTimeout(() => { | ||
| this.colResize && this.setResizerHeight(); |
There was a problem hiding this comment.
can we rename it to setColResizerHeight to make it more descriptive?
There was a problem hiding this comment.
Done
| const targetCol = e.path[0]; | ||
| targetCol.classList.add('resizer-border'); | ||
| const currentMousePos = e.clientX; | ||
| const parent = e.path[0].parentElement; |
There was a problem hiding this comment.
replace it with composedPath. or do a check to see if e.path exists if not use composedPath
There was a problem hiding this comment.
fixed.
| if (resizers.length > 0) { | ||
| resizers.forEach((item: HTMLElement) => { | ||
| item.style.height = | ||
| this.el.shadowRoot.querySelector('table').offsetHeight + 'px'; |
There was a problem hiding this comment.
can u move this line above the forEach statement. This is create reflow for every iteration since we are reading offsetHeight on each iteration. This value will remain constant.
There was a problem hiding this comment.
fixed.
srivalli-sivaramasankaran
force-pushed
the
feat/datatable-resize
branch
from
ba01b15
to
7c7da5e
Compare
Checklist:
How Has This Been Tested?