Cog ai model nginx sidecar auth #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for token in templates
…tainer and configure Add sidecar container with image and security context. Configure env variables, ports, and probes.
…plate for sidecar Create a new configmap template file for the sidecar
…et template to cog-ai-model chart Create a new SealedSecret template file in the charts/cog-ai-model/templates directory. Configure the template with the appropriate metadata and encryptedData properties.
Change: Added instructions for accessing sidecar services with NodePort, LoadBalancer, and ClusterIP types. Change: Updated existing instruction to use 'port-forward' command instead of 'kubectl proxy'
Add a new sidecar container to enable authorization token. It creates a service in port TCP 80 to retrieve request and authorize it to proxy that request to COG later. Disabled by default.
Changes to the Helm chart values file and addition of Nginx auth. Added support for Bearer Token authentication using sidecar container. Users can enable authentication by setting sidecar.enable to true and providing required values. Optionally, users can use sealed secrets to store and retrieve the token.
sergiotejon
requested review from
kerunaru,
Muriano,
alepalma91 and
jdominguez408
alepalma91
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Añade soporte para un sidecar con Nginx que permite authorizar un Bearer Token.
Es una configuración opcional, desactivada por defecto.
Además, permite crear el token, junto con su secret, a partir de SealedSecret. Para simplificar el asunto. En cualquier caso, esto es opcional. Siempre se podrá crear el secret del token por otros medios y usarlo luego mediante una variable de entorno llamada TOKEN.
Todo esto debería estar documentado en el README.