chore(release): dev to main #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: favicon reactivity in settings modal
* fix(HelpdeskSearch): Check for existing index accurately Checking for index only is problematic as frappe.clear_cache only removes docs and not the index * fix(HelpdeskSearch): Handle types and other exceptions * style: isort * style: Ignore flake warning for fn declaration * style(flake8): SIM104
Also return scores
Split query string correctly. Ignore long whitespace
- noun phrases - or queries (worst case)
capitalized stopwords weren't being removed - Add more stopwords - Add brown corpora to get noun phrases
fix(HelpdeskSearch): Add report to evaluate search and improvements with the same
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 31.35% 30.96% -0.39%
==========================================
Files 61 63 +2
Lines 2019 2070 +51
==========================================
+ Hits 633 641 +8
- Misses 1386 1429 +43 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.