Feature #173: Vue Body Teleport support #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error TS2742: The inferred type of 'startServer' cannot be named without a reference to 'vite-ssr/node_modules/vite'. This is likely not portable. A type annotation is necessary.
|
@frandiox what do you think about this PR? |
|
Hi @frandiox ! Can we merge this PR please? |
|
I have the same issue and would like to have this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173: Like described in the official documentation of vue, we should consider to use an own DOM node for Vue body teleports:
Avoid targeting body when using Teleports and SSR together - usually,
<body>will contain other server-rendered content which makes it impossible for Teleports to determine the correct starting location for hydration. Instead, prefer a dedicated container, e.g.<div id="teleported"></div>which contains only teleported content.We have two possible solutions:
1. Teleport components are rendered only on client side (no hydration node mismatch).
But that eliminates a huge bonus from using SSR, as web crawlers (SEO) are not able to traverse JS. E.g. main menu as offcanvas side menu.
2. Required SSR rendering of body teleport components, by using a unique DOM node outside app node (solves hydration node mismatch).
with
index.htmllike:This is a solution for SSR body teleports only! Teleports inside root element (
#app) should currently be wrapped asClientOnly.