Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for @vueuse/head versions >1.0.0 #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ManneW
Copy link

@ManneW ManneW commented Mar 27, 2023

The purpose of the changes in this PR is to add support for the consumer of the library to use newer versions of the @vueuse/head library, while still retaining compatibility with lower versions.

To have reliable test cases to ensure both versions are working, the structure of how the test fixtures are provided access to the vite-ssr build is slightly modified.

Feel free to ask any questions or add feedback about the implementation and I'll be happy to assist.

@thomasowow
Copy link
Contributor

Fixes #195

@ManneW
Copy link
Author

ManneW commented Mar 31, 2023

I think this also fixes #194 🙂

@SuzanaK
Copy link

SuzanaK commented Apr 13, 2023

Any idea when this can be merged?

@phlegx
Copy link

phlegx commented May 19, 2023

@frandiox the package @vueuse/head gets deprecated in the coming months.

See here: vueuse/head

In the coming months, the @vueuse/head package will be deprecated. If you're setting up this package on a new project, you should use the @unhead/vue package directly.

@frandiox
Copy link
Owner

Thanks a lot for this PR, and sorry for the late response!
Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) 🤔
Will try to come back to this in the weekend 🙏

@thomasowow
Copy link
Contributor

thomasowow commented May 24, 2023

Thanks a lot for this PR, and sorry for the late response! Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) thinking Will try to come back to this in the weekend pray

Make sure to undo/update the change from #195 before this PR is merged.

@phlegx
Copy link

phlegx commented May 26, 2023

@frandiox thank you so much! If dependencies like @unhead/vue are upgraded, we should also upgrade @rollup/plugin-replace to v5.x. Like described in #201 warnings related to @rollup/plugin-replace can be solved.

@phlegx
Copy link

phlegx commented Jun 8, 2023

Hi! News from here? I can help to test the new planned version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants