Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Preload fonts in HTML #5613

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 13, 2020

Fixes #5572

@auto-label auto-label bot added the chore label Nov 13, 2020
@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/kktkzm6tq
✅ Preview: https://open-event-frontend-git-font-preload.eventyay.vercel.app

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 13, 2020

@iamareebjamal I am going to update my pr but I have exams and online classes that's why I am not able to do

Plz give me chance I will update it .

In my pr only need to the change href of "open event "

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5613 (0c250f9) into development (5ae5017) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5613      +/-   ##
===============================================
+ Coverage        23.70%   23.73%   +0.03%     
===============================================
  Files              498      498              
  Lines             5257     5270      +13     
  Branches            44       47       +3     
===============================================
+ Hits              1246     1251       +5     
- Misses            4005     4011       +6     
- Partials             6        8       +2     
Impacted Files Coverage Δ
app/components/widgets/forms/link-field.ts 65.21% <0.00%> (-9.79%) ⬇️
app/utils/dictionary/social-media.ts 92.30% <0.00%> (-7.70%) ⬇️
app/components/modals/modal-base.js 24.24% <0.00%> (-0.76%) ⬇️
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️
app/routes/index.js 78.57% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/controllers/admin/users/list.js 0.00% <0.00%> (ø)
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae5017...0c250f9. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 8cdcf37 into fossasia:development Nov 13, 2020
@iamareebjamal iamareebjamal deleted the font-preload branch November 13, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Site Speed: Preload key requests
2 participants