-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change acknowledgement text and button #5611
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
be2588a
Acknowledgement Text and Button
Saumyachitransh01 d17f03c
Internal Links added
Saumyachitransh01 069962c
Links
Saumyachitransh01 744b672
Resolving Repetition
Saumyachitransh01 70cd61a
Update order-form.hbs
Saumyachitransh01 260e2be
Update order-form.hbs
Saumyachitransh01 660fb29
Update order-form.hbs
Saumyachitransh01 5251661
link placeholder
Saumyachitransh01 934a87a
terms privacy
Saumyachitransh01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,12 +279,16 @@ | |
{{t 'Acknowledgement'}} | ||
</h4> | ||
<p> | ||
{{t | ||
'By clicking "Pay Now", I acknowledge that I have read and that I agree with all the terms of services and privacy policy of Open Event.'}} | ||
<GetText | ||
@message = {{t 'By clicking "{{orderState}}", I acknowledge that I have read and that I agree with the {{terms}} and {{privacy}} on this website.' | ||
orderState=(if this.isPaidOrder (t "Proceed to Checkout") (t "Order Now"))}} as |text placeholder|> | ||
{{~#if (eq placeholder 'terms')}}<a href="/terms">terms of services</a>{{~/if~}} | ||
{{~#if (eq placeholder 'privacy')}}<a href="/privacy">privacy policy</a>{{~/if~}} | ||
</GetText> | ||
</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use relative links. |
||
<div class="center aligned"> | ||
<button type="submit" class="ui teal submit button">{{t 'Proceed to Checkout'}}</button> | ||
<button type="submit" class="ui teal submit button">{{if this.isPaidOrder (t "Proceed to Checkout") (t "Order Now") }}</button> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</form> | ||
</form> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
terms='<a href="/terms">terms of services</a>'
andprivacy='<a href="/privacy">privacy policy</a>'
like in orderState?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was showing error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to wrap that in string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried and didn't worked with that too. Browser was showing no link only the text inside quotes