Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle www and value changes in link-field #5597

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/k4kedwmgf
✅ Preview: https://open-event-frontend-git-social-link-www.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #5597 (e67b1e1) into development (7ecc1da) will decrease coverage by 0.02%.
The diff coverage is 46.15%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5597      +/-   ##
===============================================
- Coverage        23.75%   23.73%   -0.03%     
===============================================
  Files              498      498              
  Lines             5257     5270      +13     
  Branches            44       47       +3     
===============================================
+ Hits              1249     1251       +2     
- Misses            4002     4011       +9     
- Partials             6        8       +2     
Impacted Files Coverage Δ
app/models/social-link.js 0.00% <0.00%> (ø)
app/components/widgets/forms/link-field.ts 65.21% <50.00%> (-9.79%) ⬇️
app/utils/dictionary/social-media.ts 92.30% <66.66%> (-7.70%) ⬇️
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/components/modals/modal-base.js 24.24% <0.00%> (-0.76%) ⬇️
app/components/widgets/forms/image-upload.js 22.64% <0.00%> (-0.44%) ⬇️
app/routes/index.js 78.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecc1da...e67b1e1. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 6134940 into fossasia:development Nov 13, 2020
@iamareebjamal iamareebjamal deleted the social-link-www branch November 13, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant