Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Order Page: Remove empty spaces #5561

Merged
merged 4 commits into from
Nov 11, 2020
Merged

fix: Order Page: Remove empty spaces #5561

merged 4 commits into from
Nov 11, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 10, 2020 •
edited
Loading

Fixes #5559 #5566

Short description of what this resolves:

Remove spaces between boxes. Enhance mobile view.

Changes proposed in this pull request:

  • remove spaces between boxes.
  • Event Information box is visible in mobile view.
  • Order summary table is also be a table in mobile view as well.
  • Buttons "Tickets" and "Invoice should have some spacing in between.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before
000111111111111

d1

after

a1

b1

c1

@vercel
Copy link

vercel bot commented Nov 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7vlcssx8x
✅ Preview: https://open-event-frontend-git-fix-5559.eventyay.vercel.app

@auto-label auto-label bot added the fix label Nov 10, 2020
vsasvipul0605
vsasvipul0605 previously approved these changes Nov 10, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited
Loading

Codecov Report

Merging #5561 (af10c3e) into development (a0d1679) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5561   +/-   ##
============================================
  Coverage        23.71%   23.71%           
============================================
  Files              498      498           
  Lines             5255     5255           
  Branches            44       44           
============================================
  Hits              1246     1246           
  Misses            4003     4003           
  Partials             6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1679...af10c3e. Read the comment docs.

mariobehling
mariobehling requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep "Download tickets" and "Download Invoice" in the right side column.

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal sir, implemented suggested changes. This PR now solves #5566 #5559 both

@iamareebjamal
Copy link
Member

Before, the buttons spanned the width of entire right column, now they don't

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, is it good. please review.

k1

iamareebjamal
iamareebjamal reviewed Nov 11, 2020
View reviewed changes
app/styles/partials/overrides.scss Outdated
@@ -82,3 +82,8 @@ body.dimmable.undetached.dimmed {
margin-left: auto !important;
margin-top: auto !important;
}

.display-flex {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d-flex class is already defined. Just add a class for space between

iamareebjamal
iamareebjamal reviewed Nov 11, 2020
View reviewed changes
app/templates/orders/view.hbs Outdated
<Orders::EventInfo
@data={{this.model.order}} />
<br/>
<div class="{{if (eq this.device.isMobile false) 'display-flex'}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to check that it is not mobile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal sir, if we implement this class at mobile device, buttons are not stacking on one another.

explain 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no need for stacking

@iamareebjamal iamareebjamal merged commit 70d2605 into fossasia:development Nov 11, 2020
@sachinchauhan2889 sachinchauhan2889 mentioned this pull request Nov 11, 2020
Closed
@sachinchauhan2889 sachinchauhan2889 deleted the fix-5559 branch November 13, 2020 16:31
@sachinchauhan2889 sachinchauhan2889 mentioned this pull request Nov 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@vsasvipul0605 vsasvipul0605 vsasvipul0605 left review comments

@mariobehling mariobehling Awaiting requested review from mariobehling

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order Page: Remove empty spaces
4 participants
@sachinchauhan2889 @iamareebjamal @mariobehling @vsasvipul0605