Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update translations and l10n commands #5487

Merged
merged 1 commit into from
Nov 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ install: yarn

script:
- touch .env
- node scripts/l10n.js generate
- yarn l10n:generate
- yarn lint
- COVERAGE=true yarn test
- ROOT_URL=open-event-frontend ember build -prod
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ARG api_host
ARG google_api_key
ENV API_HOST=$api_host
ENV GOOGLE_API_KEY=$google_api_key
RUN node scripts/l10n.js generate && \
RUN yarn l10n:generate && \
touch .env && \
JOBS=1 yarn build -prod

Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ The Open Event Frontend can be easily deployed on a variety of platforms. Detail

**Note**: Please follow [installation steps](/docs/installation/local.md#steps) listed above carefully before running

Unfortunately, no one reads the note above, so please just run the following commands when setting up for the first time:
- `yarn`
- `cp .env.example .env`
- `yarn l10n:generate`

Running:
- `yarn start`
- Visit your app at [http://localhost:4200](http://localhost:4200).

Expand Down
6 changes: 3 additions & 3 deletions docs/installation/local.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ cd open-event-frontend

* `yarn`
* `cp .env.example .env`
* `node scripts/l10n.js generate`
* `yarn l10n:generate`

#### Important Notes
- Open Event Frontend supports [FastBoot](https://github.com/ember-fastboot/ember-cli-fastboot) which is disabled for the development environment and is controlled by the flag `FASTBOOT_DISABLED` in the `.env` file.

- **Only for Mac users** :- If while running `node scripts/l10n.js generate` you encounter `Get-Text Finding Error` or `Ember-l10n Missing Dependencies`.
Please use this before running `node scripts/l10n.js generate` again :
- **Only for Mac users** :- If while running `yarn l10n:generate` you encounter `Get-Text Finding Error` or `Ember-l10n Missing Dependencies`.
Please use this before running `yarn l10n:generate` again :
```sh
brew reinstall gettext
brew link --force gettext
Expand Down
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
"lint:js": "eslint --cache --fix app ember-cli-build.js testem.js tests config",
"lint:scss": "sass-lint -c .sass-lint.yml --verbose",
"lint:hbs": "ember-template-lint --fix ."
"lint:hbs": "ember-template-lint --fix .",
"l10n:extract": "node scripts/l10n.js extract",
"l10n:update": "node scripts/l10n.js update",
"l10n:generate": "node scripts/l10n.js extract"
},
"pre-commit": {
"run": [
Expand Down
Loading