Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Empty Spaces between Boxes in Event Dashboard Page #5464

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5463

Short description of what this resolves:

This PR removes empty space between tables/boxes in event dashboard page.

Changes proposed in this pull request:

-Remove empty spaces between tables

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

aaaaaaaaaaaaaaaa

@vercel
Copy link

vercel bot commented Nov 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iymw23s5n
✅ Preview: https://open-event-frontend-git-remove-empty-area.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #5464 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5464   +/-   ##
============================================
  Coverage        23.23%   23.23%           
============================================
  Files              493      493           
  Lines             5169     5169           
  Branches            38       38           
============================================
  Hits              1201     1201           
  Misses            3963     3963           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9f217...f5b4f8c. Read the comment docs.

@iamareebjamal
Copy link
Member

Before and after screenshots

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal
before

bbbbbbbbbbbbbb

after

aaaaaaaaaaaaaaaa

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Works for me.

@iamareebjamal iamareebjamal merged commit 025080d into fossasia:development Nov 3, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the remove-empty-area branch November 3, 2020 16:29
akash2408 pushed a commit to akash2408/open-event-frontend that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Adding content of boxes results in large empty areas
3 participants