Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only prevent fulfilled or pending order users from deletion #5432

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 30, 2020

Fixes #5430

@auto-label auto-label bot added the fix label Oct 30, 2020
@vercel
Copy link

vercel bot commented Oct 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/kdfswbe0v
✅ Preview: https://open-event-frontend-git-user-delete-order.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #5432 into development will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5432      +/-   ##
===============================================
- Coverage        23.32%   23.25%   -0.07%     
===============================================
  Files              493      493              
  Lines             5158     5160       +2     
  Branches            38       38              
===============================================
- Hits              1203     1200       -3     
- Misses            3950     3955       +5     
  Partials             5        5              
Impacted Files Coverage Δ
app/routes/account/danger-zone.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cefe2...03ae802. Read the comment docs.

@iamareebjamal iamareebjamal merged commit af11e15 into fossasia:development Oct 30, 2020
@iamareebjamal iamareebjamal deleted the user-delete-order branch October 30, 2020 18:27
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Account: Admin and User themselves Not Able to Delete Account
1 participant