feat: Add to Google Calendar #5392
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pvbay43ay |
|
Why are you creating 50 PRs for the same issue. Solve it in one PR |
| import Component from '@ember/component'; | ||
| import { computed } from '@ember/object'; | ||
| import moment from 'moment'; | ||
| export default Component.extend({ |
| const params = this.get('event'); | ||
| const startparams = params.startsAt; | ||
| const endparams = params.endsAt; | ||
| const starttime = moment(startparams).tz('Asia/Kolkata').utc().format('YYYYMMDD[T]HHmmSS[Z]'); |
There was a problem hiding this comment.
The site doesn't only work for India
| const params = this.get('event'); | ||
| const startparams = params.startsAt; | ||
| const endparams = params.endsAt; | ||
| const starttime = moment(startparams).tz('Asia/Kolkata').utc().format('YYYYMMDD[T]HHmmSS[Z]'); |
There was a problem hiding this comment.
const timezone=params.timezone get the timezone and use it.
| @@ -0,0 +1,6 @@ | |||
| <div class="ui list"> | |||
| <div class="content"> | |||
| <li>{{header-date @event.startsAt}} To {{header-date @event.endsAt}}</li> | |||
There was a problem hiding this comment.
use general date helper and format it. And also I don't think it is needed here.
There was a problem hiding this comment.
i use it to give a similar format like given in the photo in the issue and i think its looking fine
There was a problem hiding this comment.
your format is not similar to this -
https://user-images.githubusercontent.com/1583873/93197307-c05ab780-f74b-11ea-8527-4cb703d739d9.png
There was a problem hiding this comment.
your format is not similar to this -
https://user-images.githubusercontent.com/1583873/93197307-c05ab780-f74b-11ea-8527-4cb703d739d9.png
previously it was same u told me to use general date helper instead of header date
isn't?
There was a problem hiding this comment.
it's wasn't same previously too, look closely
There was a problem hiding this comment.
can i make a new helper for the same format?
| <div class="ui list"> | ||
| <div class="content"> | ||
| <li>{{header-date @event.startsAt}} To {{header-date @event.endsAt}}</li> | ||
| <a href={{this.calender}}>Add To Calender</a> |
There was a problem hiding this comment.
Add to Google calendar, or add a google calendar icon.
|
Fix travis build |
yes iam doing that and making an helper for the same format of date used similar in give image. |
|
You can use general-date helper and pass in the required date format |
sir now iam gettting confused i used general-date but @maze-runnar saying format is not similar with this image: https://user-images.githubusercontent.com/1583873/93197307-c05ab780-f74b-11ea-8527-4cb703d739d9.png |
| params = this.args.event; | ||
|
|
||
| get timezone() { | ||
| return `GMT${moment.tz("Asia/Kolkata").format('Z')}`; |
There was a problem hiding this comment.
This project is not just for India
app/helpers/calender-date.js
Outdated
| import Helper from '@ember/component/helper'; | ||
| import moment from 'moment'; | ||
|
|
||
| export function calenderDate(params) { |
There was a problem hiding this comment.
No need of this helper. Remove
Because you didn't pass the date format in the helper |
Codecov Report
@@ Coverage Diff @@
## development #5392 +/- ##
===============================================
+ Coverage 23.29% 23.32% +0.02%
===============================================
Files 492 493 +1
Lines 5147 5158 +11
Branches 38 38
===============================================
+ Hits 1199 1203 +4
- Misses 3943 3950 +7
Partials 5 5
Continue to review full report at Codecov.
|
|
Still wrong |
can u please tell what is wrong because i think date format is correct now |
|
Countless spelling mistakes, style errors, formatting errors, etc |
|
See the changes now |
thanks for suggestions |
iamareebjamal
changed the title
|
Complexity increasing per file
==============================
- app/components/public/add-to-calender.ts 1
See the complete overview on Codacy |
|
sir don't u need yahoo ,ical and outlook calender features now ? |
|
We do |
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Fixes #5072
Short description of what this resolves:
For Now I Added Only Add to Google Calender feature
Changes proposed in this pull request:
Checklist
developmentbranch.