Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ember-models-table #5379

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 25, 2020

After #5291, the last usage of library was removed

@auto-label auto-label bot added the chore label Oct 25, 2020
@vercel
Copy link

vercel bot commented Oct 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/li3nrc08m
✅ Preview: https://open-event-frontend-git-rm-models-table.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2020

This pull request fixes 2 alerts when merging 7942777 into e639adb - view on LGTM.com

fixed alerts:

  • 2 for Implicit operand conversion

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #5379 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5379   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              491      491           
  Lines             5232     5232           
  Branches            37       37           
============================================
  Hits              1192     1192           
  Misses            4035     4035           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e639adb...7942777. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 90a4255 into fossasia:development Oct 25, 2020
@iamareebjamal iamareebjamal deleted the rm-models-table branch October 25, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant