-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MD5Sum of the tarfile as the task version #931
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 85.82% 85.74% -0.08%
==========================================
Files 246 246
Lines 23494 23486 -8
Branches 2655 2321 -334
==========================================
- Hits 20164 20139 -25
- Misses 2888 2898 +10
- Partials 442 449 +7
Continue to review full report at Codecov.
|
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com
TL;DR
In script mode, we rely on the hash of the generated tar file to idempotent-ly register tasks/workflows. Because tar file metadata changes every time, we end up with a different version S3 path for the task. Because we use the script md5 hash as the task version, admin rejects the registration because the content of the task proto changed.
This PR unifies versioning logic to rely on the tar file content md5 for the task version
Type