Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back python interface to base remote class #929

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

wild-endeavor
Copy link
Contributor

Signed-off-by: Yee Hing Tong wild-endeavor@users.noreply.github.com

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #929 (173a2cc) into master (bd5c5b5) will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   85.87%   85.90%   +0.03%     
==========================================
  Files         246      246              
  Lines       23435    23459      +24     
  Branches     2314     2649     +335     
==========================================
+ Hits        20124    20153      +29     
- Misses       2862     2864       +2     
+ Partials      449      442       -7     
Impacted Files Coverage Δ
flytekit/interfaces/cli_identifiers.py 48.38% <ø> (ø)
flytekit/remote/launch_plan.py 78.43% <ø> (-0.42%) ⬇️
flytekit/remote/remote.py 35.07% <0.00%> (-0.66%) ⬇️
flytekit/remote/task.py 87.50% <ø> (-0.50%) ⬇️
flytekit/remote/workflow.py 93.93% <ø> (-0.10%) ⬇️
flytekit/remote/remote_callable.py 73.68% <85.71%> (+1.80%) ⬆️
flytekit/interfaces/random.py 100.00% <0.00%> (ø)
flytekit/clis/flyte_cli/main.py 44.29% <0.00%> (ø)
flytekit/tools/module_loader.py 58.18% <0.00%> (ø)
flytekit/types/directory/types.py 94.16% <0.00%> (+0.04%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5c5b5...173a2cc. Read the comment docs.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor merged commit a038c19 into master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants