Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client credentials should never be cleared #922

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Apr 7, 2022

Signed-off-by: Ketan Umare ketan.umare@gmail.com

TL;DR

In the case when client credentials have expired or corrupted, the
default _refresh_credentials_standard flow will automatically force
the client to refresh_access_token.

But, in a happy case, the clear, unnecessarily removes the client creds,
thus forcing an auth to be retriggered

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

In the case when client credentials have expired or corrupted, the
default `_refresh_credentials_standard` flow will automatically force
the client to `refresh_access_token`.

But, in a happy case, the clear, unnecessarily removes the client creds,
thus forcing an auth to be retriggered

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #922 (6c71720) into master (0f86bb2) will decrease coverage by 0.77%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   86.43%   85.66%   -0.78%     
==========================================
  Files         243      243              
  Lines       23243    22269     -974     
  Branches     2618     2285     -333     
==========================================
- Hits        20091    19076    -1015     
- Misses       2711     2745      +34     
- Partials      441      448       +7     
Impacted Files Coverage Δ
flytekit/clients/raw.py 61.60% <0.00%> (-5.41%) ⬇️
flytekit/clis/auth/auth.py 43.94% <40.00%> (-15.81%) ⬇️
tests/flytekit/unit/cli/auth/test_auth.py 100.00% <100.00%> (+6.06%) ⬆️
tests/flytekit/unit/extras/tasks/test_shell.py 81.81% <0.00%> (-18.19%) ⬇️
flytekit/models/admin/task_execution.py 42.10% <0.00%> (-11.42%) ⬇️
flytekit/interfaces/cli_identifiers.py 39.62% <0.00%> (-8.77%) ⬇️
flytekit/remote/executions.py 57.47% <0.00%> (-8.27%) ⬇️
flytekit/clis/sdk_in_container/local_cache.py 71.42% <0.00%> (-6.35%) ⬇️
tests/flytekit/unit/remote/test_sandbox.py 53.19% <0.00%> (-6.07%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f86bb2...6c71720. Read the comment docs.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor merged commit df160b7 into master Apr 7, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants