Skip version 1.45.0 of grpcio and grpcio-status #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 240 240
Lines 23145 23145
Branches 2610 2610
=======================================
Hits 20005 20005
Misses 2693 2693
Partials 447 447 Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Apr 5, 2022
myz540
pushed a commit
to ProjectAussie/flytekit
that referenced
this pull request
Apr 11, 2022
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com
TL;DR
Version 1.45.0 of grpcio was yanked, but simply adding only that constraint was not enough as
grpcio-status==1.45.0was not yanked.Type
Are all requirements met?
Complete description
Version 1.45.0 of
grpciowas yanked, but we were also pulling in grpcio-status==1.45.0. grpc/grpc#29310 is an issue for a similar grpc package, but just to unblock flytekit master, let's force skipping thegrpcio-status==1.45.0for now.Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA