Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error #904

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Fix lint error #904

merged 4 commits into from
Mar 31, 2022

Conversation

pingsutw
Copy link
Member

Signed-off-by: Kevin Su pingsutw@apache.org

TL;DR

Error:

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repozuci9iid/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/home/runner/.cache/pre-commit/repozuci9iid/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1129, in patched_main
    patch_click()
  File "/home/runner/.cache/pre-commit/repozuci9iid/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1115, in patch_click
    from click import _unicodefun  # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/home/runner/.cache/pre-commit/repozuci9iid/py_env-python3/lib/python3.8/site-packages/click/__init__.py)

It's related to this issue psf/black#2964 (comment)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

pin click version

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #904 (43d2a4d) into master (952eb9f) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         234      234           
  Lines       22875    22875           
  Branches     2577     2577           
=======================================
  Hits        19782    19782           
  Misses       2655     2655           
  Partials      438      438           
Impacted Files Coverage Δ
flytekit/clients/raw.py 66.55% <0.00%> (ø)
tests/flytekit/unit/core/test_serialization.py 93.46% <ø> (ø)
tests/flytekit/unit/cli/test_cli_helpers.py 100.00% <100.00%> (ø)
tests/flytekit/unit/core/test_type_hints.py 96.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952eb9f...43d2a4d. Read the comment docs.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit 1407dc7 into master Mar 31, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
* Fix lint error

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fix lint error

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fix lint error

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Fix lint error

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants