Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth comparison #895

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Fix auth comparison #895

merged 3 commits into from
Mar 23, 2022

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Mar 22, 2022

Signed-off-by: Yee Hing Tong wild-endeavor@users.noreply.github.com

TL;DR

Users might not do

from flytekit.configuration import AuthType
PlatformConfig(auth_type=AuthType.BASIC)

they might just write PlatformConfig(auth_mode="basic") in which case the comparison breaks.

Type

  • Bug Fix
  • Feature
  • Plugin

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #895 (342cf8a) into master (d1702fc) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         231      231              
  Lines       22684    22698      +14     
  Branches     2552     2553       +1     
==========================================
+ Hits        19632    19643      +11     
- Misses       2625     2628       +3     
  Partials      427      427              
Impacted Files Coverage Δ
flytekit/configuration/__init__.py 95.00% <ø> (-0.02%) ⬇️
flytekit/remote/remote.py 40.93% <ø> (ø)
flytekit/clients/raw.py 66.55% <60.00%> (-0.24%) ⬇️
tests/flytekit/unit/clients/test_raw.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1702fc...342cf8a. Read the comment docs.

@wild-endeavor wild-endeavor merged commit b08e2b6 into master Mar 23, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants