Added RawOutputDataConfig in ExecutionSpec #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 86.47% 86.51% +0.04%
==========================================
Files 230 230
Lines 22075 22105 +30
Branches 2459 2465 +6
==========================================
+ Hits 19090 19125 +35
+ Misses 2578 2576 -2
+ Partials 407 404 -3
Continue to review full report at Codecov.
|
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
| @@ -89,6 +89,7 @@ class Options(object): | |||
| auth_role: typing.Optional[common_models.AuthRole] = None | |||
| labels: typing.Optional[common_models.Labels] = None | |||
| annotations: typing.Optional[common_models.Annotations] = None | |||
| raw_output_data_config: typing.Optional[common_models.RawOutputDataConfig] = None | |||
There was a problem hiding this comment.
Can you add it to the Args list on line 82 also?
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
approved these changes
Mar 16, 2022
myz540
pushed a commit
to ProjectAussie/flytekit
that referenced
this pull request
Apr 11, 2022
* Added RawOutputDataConfig in ExecutionSpec Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated idl Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated idl Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated idl Signed-off-by: Kevin Su <pingsutw@apache.org> * Updated args Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
Added RawOutputDataConfig in ExecutionSpec
Type
Are all requirements met?
Complete description
models.execution.pyfrom_flyte_idlandto_flyte_idlTracking Issue
flyteorg/flyte#2230
Follow-up issue
NA