Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup docs, config docs #883

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Cleanup docs, config docs #883

merged 5 commits into from
Mar 10, 2022

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

Just some docs

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor changed the title Cleanup docs Cleanup docs, config docs Mar 10, 2022
flytekit/remote/remote.py Outdated Show resolved Hide resolved
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
Copy link
Contributor Author

@kumare3 can you take one more look please?

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #883 (2096119) into master (2946952) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   86.47%   86.47%   -0.01%     
==========================================
  Files         230      230              
  Lines       22078    22075       -3     
  Branches     2459     2459              
==========================================
- Hits        19093    19090       -3     
  Misses       2578     2578              
  Partials      407      407              
Impacted Files Coverage Δ
flytekit/clients/raw.py 66.78% <ø> (ø)
flytekit/configuration/__init__.py 95.01% <ø> (-0.06%) ⬇️
flytekit/remote/__init__.py 100.00% <ø> (ø)
flytekit/remote/component_nodes.py 69.33% <ø> (ø)
flytekit/remote/remote.py 40.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2946952...2096119. Read the comment docs.

@kumare3 kumare3 merged commit e0dcac5 into master Mar 10, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants