-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module name parameter for workflows and tasks #745
Conversation
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
This is just an implementation to make it work with a self contained file. This was not tested, also other side effects are not considered. But since the parameter is optional it should be backward compatible. |
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 85.60% 85.63% +0.03%
==========================================
Files 342 342
Lines 28926 28989 +63
Branches 2381 2378 -3
==========================================
+ Hits 24763 24826 +63
- Misses 3530 3531 +1
+ Partials 633 632 -1
Continue to review full report at Codecov.
|
Signed-off-by: Emirhan Karagül <emirhan350z@gmail.com>
TL;DR
This PR adds an optional parameter to workflow and task types to make the module name explicitly available.
So that it can be avoided that the workflows and tasks default to
__main__.my_task
and__main__.my_workflow
, by overriding module name in tasks and workflowsType
Are all requirements met?
Complete description
Added extra optional parameter
module_name
to workflow and task definitions.Tracking Issue
flyteorg/flyte#1813
Follow-up issue
NA