This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
#patch Allow unscoped filtering on all NamedEntity(Metadata) fields #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where attempting to filter the list endpoint for NamedEntities on any of the base fields (such as
name
) will incorrectly exclude any records which do not have a metadata entry.This is due to the generated query containing a
where
clause pointing at the metadata table, instead of the primary table.For
NamedEntitiy
objects, the behavior we want is that the core and metadata fields are treated all as a single struct. The fact that we store the metadata in a separate table shouldn't require that filters be scoped.This fixes the issue by leveraging some customization logic we already have for execution fields, but allows replacing of the filter
entity
instead. Forstate
anddescription
, we want the filter to be against theNamedEntityMetadata
type. For all others, we want to useNamedEntity
.