Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Gcs remote data #121

Merged
merged 18 commits into from
Sep 3, 2020
Merged

Gcs remote data #121

merged 18 commits into from
Sep 3, 2020

Commits on Sep 1, 2020

  1. [wip] signed GCS URL

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e41ea37 View commit details
    Browse the repository at this point in the history

  2. fix lint error

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c08ced5 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c787862 View commit details
    Browse the repository at this point in the history

  4. Upgrade modules

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d485760 View commit details
    Browse the repository at this point in the history

  5. Use proper resource name 

    Although this doesn't seem to be required, it is better to do things according
to API doc.
    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    32cd3e5 View commit details
    Browse the repository at this point in the history

  6. Impersonate the signingPrincipal to get object attributes 

    This will make sure only the `signingPrincipal` needs readonly permission on the
object instead of the service account associated with flyteadmin.
    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    dc6dfce View commit details
    Browse the repository at this point in the history

  7. Implementation sounds better

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    ab7a74b View commit details
    Browse the repository at this point in the history

  8. Test factory

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    371e463 View commit details
    Browse the repository at this point in the history

  9. Start unit test

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    bd81d84 View commit details
    Browse the repository at this point in the history

  10. Fix digest change 

    This is because of introducing of google.golang.org/protobuf
    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    41cd0e5 View commit details
    Browse the repository at this point in the history

  11. Extract interfaces

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    efc0c1e View commit details
    Browse the repository at this point in the history

  12. This requires ADC

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    2e5bd3d View commit details
    Browse the repository at this point in the history

  13. Unit test it

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    07c3c1c View commit details
    Browse the repository at this point in the history

  14. Fix copy pasta

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b3ca5ff View commit details
    Browse the repository at this point in the history

  15. Test more

    @honnix
    honnix committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    93d8794 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Remove misleading comment

    @honnix
    honnix committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5ae7ee4 View commit details
    Browse the repository at this point in the history

  2. Downgrade deps

    @honnix
    honnix committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    9d62d5e View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @honnix
    honnix committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    02c9eae View commit details
    Browse the repository at this point in the history