This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Allow random cluster selection when no override #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there is no override in resource table, we should allow the code to go through and apply non-label based weighted random selection.
honnix
requested review from
anandswaminathan,
EngHabu,
katrogan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 62.32% 62.39% +0.07%
==========================================
Files 104 104
Lines 7753 7752 -1
==========================================
+ Hits 4832 4837 +5
+ Misses 2351 2345 -6
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EngHabu
reviewed
Aug 24, 2020
anandswaminathan
approved these changes
Aug 24, 2020
katrogan
approved these changes
Aug 24, 2020
honnix
changed the title
schottra
added a commit
that referenced
this pull request
Sep 8, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
In case there is no override in resource table, we should allow the code to go through and apply non-label based weighted random selection. Close flyteorg/flyte#481
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
In case there is no override in resource table, we should allow the code to go through and apply non-label based weighted random selection.
Type
Are all requirements met?
Complete description
As commented, it makes more sense to let the code go through and apply different selection.
BTW these unit tests relies on
GOPATHand we should fix that.Tracking Issue
Will create later
https://github.com/lyft/flyte/issues/
Follow-up issue
NA