[camera, google_sign_in, espresso] Bump guava to version 33.3.1.
#7773
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2024 16:45
github-actions
bot
added
p: camera
p: espresso
p: google_sign_in
platform-android
labels
reidbaker
approved these changes
Oct 3, 2024
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2024
flutter/packages@7c97c88...429650f 2024-10-03 34871572+gmackall@users.noreply.github.com [camera, google_sign_in, espresso] Bump guava to version `33.3.1`. (flutter/packages#7773) 2024-10-03 stuartmorgan@google.com [video_player] Remove -Werror from Android build (flutter/packages#7776) 2024-10-03 echo.ellet@gmail.com [pigeon] chore(readme): deprecated command of running pigeon (flutter/packages#7761) 2024-10-02 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.9.1 to 1.9.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7607) 2024-10-02 43759233+kenzieschmoll@users.noreply.github.com Add percentile computations to benchmark scores (flutter/packages#7760) 2024-10-02 stuartmorgan@google.com [various] Unpin some dev dependencies (flutter/packages#7762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#155458
Fixes flutter/flutter#154586
Bumps Guava to
33.3.1, as from what I can tell we were essentially hitting google/guava#7397, from a comment on the issue:I believe this maintainers suspicions were warranted, as it seems AGP was complaining in our case!
That issue was fixed in version
33.3.1of Guava. Verified that I could re-create the failure in the first issue, and then verified that it was fixed with no additional proguard rules by upgrading the Guava version used by thegoogle_sign_inplugin. Decided to make the upgrade everywhere we use guava, so we don't hit it in another plugin later.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.