Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Switch to flutter test #4348

Merged

Conversation

stuartmorgan
Copy link
Contributor

For non-web platforms, flutter drive is deprecated. This switches those platforms from flutter drive to flutter test. This makes the logic to check for test driver files web-specific, since flutter test doesn't require a driver.

Removes support for the legacy test-in-test_driver-directory structure, which is no longer used anywhere in the repository.

Also includes a minor drive-by fix to the way we do process output, noticed while manually testing. Instead of adding all stdout, and only then adding all stderr, this adds both then waits for both, which should allow interleaving of stdout and stderr in the terminal.

Fixes flutter/flutter#105634

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023
@auto-submit auto-submit bot merged commit 38745bf into flutter:main Jul 5, 2023
69 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 6, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 6, 2023
flutter/packages@7042079...771ec9b

2023-07-06 stuartmorgan@google.com [ci] Enable LUCI Dart unit tests (flutter/packages#4378)
2023-07-06 stuartmorgan@google.com [ci] Bring up LUCI Linux custom package tests (flutter/packages#4382)
2023-07-06 tarrinneal@gmail.com [pigeon] adds generate option for example pigeons (flutter/packages#4370)
2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Allows redirect only GoRoute to be part of RouteMatchList (flutter/packages#4315)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.5.0 to 20.6.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4359)
2023-07-06 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix a crash when casting NSNull to an Array (flutter/packages#4289)
2023-07-06 hello@kamil.id [google_sign_in_web] Fixes force unwrap on values that can be null (flutter/packages#4374)
2023-07-05 engine-flutter-autoroll@skia.org Roll Flutter from 590ef2d to 35085c3 (3 revisions) (flutter/packages#4379)
2023-07-05 43054281+camsim99@users.noreply.github.com [camerax] Fixes `unawaited_futures` violations (flutter/packages#4337)
2023-07-05 stuartmorgan@google.com [ci] Remove `starqlteue` from FTL tests (flutter/packages#4375)
2023-07-05 stuartmorgan@google.com [tools] Switch to `flutter test` (flutter/packages#4348)
2023-07-05 joshuapetitma@yahoo.com [flutter_markdown] Add TableCellVerticalAlignment property in markdown stylesheet (flutter/packages#3880)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugins] Update drive-examples to use flutter test
2 participants