Skip to content

Commit

Permalink
[google_sign_in] Convert Android to Pigeon (#4344)
Browse files Browse the repository at this point in the history
Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API that's intended for direct cross-plugin native use, the existing methods are all left in place, but refactored as passthroughs to the new Pigeon versions. To ensure that they aren't broken, the existing Java tests are preserved unchanged (as a "legacy" copy) with `onMethodCall` left in place for now just to allow the tests to continue to run as-is. Since that dispatches to the legacy methods, this keeps the existing coverage of those methods.

The new tests are a copy of the legacy tests, minimally translated to use the new Pigeon variants, to ensure continuity of testing to the new version.

Part of flutter/flutter#117908
  • Loading branch information
stuartmorgan authored Jul 1, 2023
1 parent d3c0d5f commit 6ab9a8b
Show file tree
Hide file tree
Showing 13 changed files with 2,401 additions and 435 deletions.
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.1.17

* Converts method channels to Pigeon.

## 6.1.16

* Updates Guava to version 32.0.1.
Expand Down

Large diffs are not rendered by default.

Loading

0 comments on commit 6ab9a8b

Please sign in to comment.