Remove android API 26 bump for validation layers #45468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
changed the title
gaaclarke
force-pushed
the
remove-26-bump
branch
from
18caed2
to
b3f033c
Compare
gaaclarke
force-pushed
the
remove-26-bump
branch
from
b3f033c
to
d0f830b
Compare
|
@zanderso this is actually a pretty big bug. I'm surprised this passed tests. This should have accidentally bumped the api to 26 for debug builds. |
I might have misread, but I think |
Oh yea, that makes sense. |
zanderso
approved these changes
Sep 6, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 6, 2023
…134158) flutter/engine@8390515...b04c2a3 2023-09-06 nshahan@google.com Update deps on DDC build targets (flutter/engine#45404) 2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 99bcee22f87d to 487cd9240571 (1 revision) (flutter/engine#45500) 2023-09-06 30870216+gaaclarke@users.noreply.github.com Remove android API 26 bump for validation layers (flutter/engine#45468) 2023-09-06 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45480) 2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4468ef79f3d7 to 99bcee22f87d (5 revisions) (flutter/engine#45495) 2023-09-06 skia-flutter-autoroll@skia.org Roll ANGLE from 55d3636b66e0 to 1b8ab5382ff6 (1 revision) (flutter/engine#45494) 2023-09-06 skia-flutter-autoroll@skia.org Roll Skia from 596a1f192faa to 4468ef79f3d7 (2 revisions) (flutter/engine#45493) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not necessary after: #45350
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.