Gesture fixes #851
Merged
Gesture fixes #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rotate now works as expected * added option to disable double clicks * fixed queryRenderedFeatures on web
|
@metafounder it would be great if you could take a look as well |
tobrun
approved these changes
Jan 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #777 by treating all gestures as a group on web. This PR supersedes #790
The reason that this is required is that some gestures share setting with others on web - and cannot be changed independently.
I also added a new variable to disable the double click to zoom gesture on web.
While testing double clicks i noticed and fixed that queryRenderedFeatures was broken for web (Wrong object type used with the gl js lib).
I also did some minor/bugfixes on the User interface widget in the example, that i also noticed to be broken while testing the changes.