added swift formatting action #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0nac0
reviewed
Dec 3, 2021
|
I'm not familiar with Swift tooling, but this looks like a good choice. |
|
@m0nac0 i requested some other reviews - and also added a maximum line width of 100 I made some more tests also comparing to swift-format. In general swift-format creates slightly more lines of code. Both of them don't seem to be fully determined by the AST of a file, but depend also on current formatting. |
tobrun
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added swift formatting based on https://github.com/nicklockwood/SwiftFormat
Swift part of #754
The second commit has only pure formatting changes no functional changes