Pass click details to feature tapped

[felix-ht]

Currently on feature tap swallows all map clicks that land on a feature. By also passing all the information to on featureTap that a user can still make the choice to treat a onFeatureTap as a normal click in his code.

In addition this is very helpful if the coordinates are needed, even if a feature has been tapped.

Note that this breaks the api of onFeatureTapped and users will have to add the new args to the function. This will be caught by the compiler tho and should be trivial to fix.

fixes #792

[ivan-ljubicic]

@felix-ht I think onMapClick should be called regardless of feature being tapped.

For example, we have layers which display different polygons (geojson data) for population number in every state/province/village etc. (covering the whole country for example). No interactions are needed for those polygons but we need to query rendered features on certain layers bellow. We would have to listen to onFeatureTapped although we don't need to know which feature was tapped, and we don't have to do anything with that feature, but we need to know point or coordinates where the user clicked. Because those polygons cover the whole country, onMapClick would never be called, which could be solved by calling onMapClick callback regardless of features tapped.

[felix-ht]

@felix-ht I think onMapClick should be called regardless of feature being tapped.

For example, we have layers which display different polygons (geojson data) for population number in every state/province/village etc. (covering the whole country for example). No interactions are needed for those polygons but we need to query rendered features on certain layers bellow. We would have to listen to onFeatureTapped although we don't need to know which feature was tapped, and we don't have to do anything with that feature, but we need to know point or coordinates where the user clicked. Because those polygons cover the whole country, onMapClick would never be called, which could be solved by calling onMapClick callback regardless of features tapped.

@LjubiTech-Maxko
The big issues with always calling onMapClick is that it is impossible to know in the onMapClick callback, if the onFeatureTapped callback will also fire. This makes it very hard to do things that should only happen if a user only clicked the map and not a feature (because the feature tap might still happen).

Additionally I will add the ability to completely disable onFeatureTapped for new layers. So the developer has full control if he cares about feature taps or not. The reason why i chose to implement on featureTapped on the native side in the first place is to avoid doing a query for rendered features form dart, as this adds quite a bit of latency to clicks.

[m0nac0]

LGTM!

Maybe already add a short note to the changelog how users can handle the breaking change?

[m0nac0]

Theoretically we could unify both click listeners and just have one click listener with a nullable parameter for the feature id.
But that would be an even more breaking change.

[felix-ht]

Theoretically we could unify both click listeners and just have one click listener with a nullable parameter for the feature id. But that would be an even more breaking change.

I thought about that option as well - but that would be a breaking change for all users of onMapClicked (which are many more than for onFeatureTapped). In addition it would make it impossible to differentiate between a click on the map and a click on feature without an id (even tho is probably of very limited use). I will add the note to the changelog.

[meeximum]

hi, is there already a plan for releasing this feature?

[felix-ht]

@meeximum i would like to wait until #795 is resolved from upstream

[m0nac0]

@meeximum If you already want to use this before the next release, you can update your dependency as shown here #695 (comment) (note that you will need to update the repository url).