-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/771 ios onstyleready reliability #775
Feature/771 ios onstyleready reliability #775
Conversation
Saw your other comment on #771 - LGTM |
@felix-ht Do you know if there is anything I should do for builds to pass? |
@AAverin no idea seems to be failing for all buids atm |
Regarding the build failure: I've encountered something similar in the past, and I'm nearly certain it's because of a malformed .netrc file. Maybe the SDK_REGISTRY_TOKEN is not found and therefore empty? |
@m0nac0 .netrc is only used on iOS but Android also seems to fail. Probably some mistake in CI configuration |
@tobrun Could you please take a look at what is in Settings => Secrets? Might be ANDROID_CI_DOWNLOADS_TOKEN property is not set |
Right. That message is even clearer regarding the missing SDK_REGISTRY_TOKEN |
Confirmed in #783 through github action run that the token is not shared to PRs coming from forks. This doesn't seem configurable, I will try finding a solution for it. This all said, if you are part of the @flutter-mapbox-gl/team, please use a direct clone of the repo instead of forking. |
https: //github.com/flutter-mapbox-gl/maps/pull/775 Co-Authored-By: Anton Averin <1481332+AAverin@users.noreply.github.com>
* Cherry-pick upstream#775 (Feature/771 ios onstyleready reliability) https: //github.com/flutter-mapbox-gl/maps/pull/775 Co-Authored-By: Anton Averin <1481332+AAverin@users.noreply.github.com>
Looking into report in #771, this PR applies proposed by @felix-ht change to improve onStyleReadyCallback reliability on iOS