FLUID-6391: Updated the docs to reference Infusion-Icons #149
Conversation
|
@jhung could you please review this PR? |
|
@jhung could you please take another look at this PR? |
|
There are a couple references to IcoMoon in the documentation which are no longer needed. For example in If removing references to IcoMoon, much of the documentation about PUAs and preserving PUAs can be simplified or removed since |
| The problem here is if we replace the image in the anchor with an icon font, any text descriptions (the alt text) will | ||
| be removed as well - causing a possible usability and accessibility issue. | ||
| The problem here is if we replace the image in the anchor with an icon font, any text descriptions (the alt text) | ||
| <!-- will be removed as well - causing a possible usability and accessibility issue. --> |
There was a problem hiding this comment.
Is this intentionally put in a comment? I think it should still be part of the text content.
| Above: An image showing the Mac OS X Characters window. The Unicode value for a custom character appears in the right | ||
| most column. | ||
| * Less browser support, although modern browsers should handle most features | ||
| * Many different ways to add to a page, but only those that allow access to the SVG markup will permit styling via CSS |
There was a problem hiding this comment.
May need to elaborate this point. Perhaps stating that embedding the SVG is the markup is the standard practice for styling SVGs with CSS.
|
|
||
| Above: An image showing the Mac OS X Characters window. The Unicode value for a custom character appears in the right | ||
| most column. | ||
| * Less browser support, although modern browsers should handle most features |
There was a problem hiding this comment.
Perhaps add a reference to https://caniuse.com/?search=svg
| most column. | ||
| * Less browser support, although modern browsers should handle most features | ||
| * Many different ways to add to a page, but only those that allow access to the SVG markup will permit styling via CSS | ||
| * Styling multi-coloured SVGs can be complex and may not always be supported |
There was a problem hiding this comment.
It's not really necessary to say that styling SVGs with multiple colours is complex.
Can you give an example where styling an SVG with multiple colours using CSS isn't supported by a browser that supports SVGs?
We are now using Infusion-Icons and no longer recomment IcoMoon.
The documentation on lines 189-254 which I believe corresponded to the "Preserving Existing Fonts" section seems to still be relevant without IcoMoon. This is to explain how to avoid conflicts with other fonts on the page. I've left it in, but changed the other locations. |
|
@jhung ready for more review. |
|
@jhung this has been updated with main and is ready for review. One thing to note is the reference to |
|
@jhung based on the discussion in the matrix channel with @greatislander and @amb26 I'm thinking that we should not merge this PR. Maybe mothball it. Eventually migrate the existing docs to the wiki or maybe one of the guides if needed, and redirect to that location from our docs, as the page is popular. We'll also want to keep tracking the SVG icon approaches and document as needed where appropriate. |
|
I'm okay with that. There are at least 3 existing wiki pages about icon fonts, SVG icons, or Icomoon. It would be good to clean or clarify the relevance of those documents as we're changing our approach. |
jobara
added
the
mothballed
https://issues.fluidproject.org/browse/FLUID-6391