Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tizen target list #1645

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Tizen target list #1645

merged 10 commits into from
Aug 27, 2024

Conversation

justinasRm
Copy link
Contributor

@justinasRm justinasRm commented Aug 6, 2024 •
edited by Marius456
Loading

Description

Made npx rnv run -p tizen/tizenmobile/tizenwatch show different emulators

Related issues

Npm releases

n/a

@justinasRm justinasRm added the e2e label Aug 6, 2024
@justinasRm justinasRm added this to the 1.1 milestone Aug 6, 2024
@justinasRm justinasRm marked this pull request as draft August 7, 2024 07:12
@Marius456 Marius456 added e2e and removed e2e labels Aug 13, 2024
@justinasRm justinasRm marked this pull request as ready for review August 14, 2024 07:07
@justinasRm justinasRm added e2e and removed e2e labels Aug 14, 2024
@Marius456 Marius456 self-requested a review August 14, 2024 07:12
GabrieleKaceviciute
GabrieleKaceviciute previously requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@GabrieleKaceviciute GabrieleKaceviciute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't show any targets on windows 10 PRO Version 22H2

C:\Users\dev\Desktop\renative\packages\template-starter>npx rnv target list -p tizen

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ $ rnv target list -p tizen                                      │
└─────────────────────────────────────────────────────────────────┘
info: Current platform: tizen
info: Current engine: @rnv/engine-rn-web (C:\Users\dev\Desktop\renative\packages\template-starter\node_modules\@rnv\engine-rn-web)
task: ○ target list ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" list-vm
√ Executing: "C:\tizen-studio\tools\sdb.exe" devices
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n T-samsung-7.0-x86
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n W-6.5-circle-x86
task: ✔ target list
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 14/08/2024, 11:31:32 | rnv@                         │
│ $ rnv target list -p tizen                                      │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/template-starter@1.0.0                            │
│ Workspace: rnv                                                  │
│ Platform (-p): tizen                                            │
│ Engine: @rnv/engine-rn-web                                      │
│ App Config (-c): template                                       │
│ Build Scheme (-s): debug                                        │
│ Supported Platforms: ios, android, androidtv, firetv, androidwear, web, tizen, tvos, webos, macos, tizenwatch, kaios, chromecast, linux, windows
│ Env Info: win32 | x64 | node v18.20.3                           │
│ Executed Time: 0h:0m:6s:791ms                                   │
│
Tizen Targets:

│ You are trying to run global rnv command in your current project.
│ This might lead to unexpected behaviour.
│ Run your rnv command with npx prefix:
│ npx rnv target list -p tizen
└─────────────────────────────────────────────────────────────────┘

C:\Users\dev\Desktop\renative\packages\template-starter>

>C:\tizen-studio\tools\emulator\bin\em-cli.bat list-vm
T-samsung-7.0-x86
W-6.5-circle-x86

@Marius456
Copy link
Contributor

doesn't show any targets on windows

C:\Users\dev\Desktop\renative\packages\template-starter>npx rnv target list -p tizen

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ $ rnv target list -p tizen                                      │
└─────────────────────────────────────────────────────────────────┘
info: Current platform: tizen
info: Current engine: @rnv/engine-rn-web (C:\Users\dev\Desktop\renative\packages\template-starter\node_modules\@rnv\engine-rn-web)
task: ○ target list ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" list-vm
√ Executing: "C:\tizen-studio\tools\sdb.exe" devices
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n T-samsung-7.0-x86
√ Executing: "C:\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n W-6.5-circle-x86
task: ✔ target list
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 14/08/2024, 11:31:32 | rnv@                         │
│ $ rnv target list -p tizen                                      │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/template-starter@1.0.0                            │
│ Workspace: rnv                                                  │
│ Platform (-p): tizen                                            │
│ Engine: @rnv/engine-rn-web                                      │
│ App Config (-c): template                                       │
│ Build Scheme (-s): debug                                        │
│ Supported Platforms: ios, android, androidtv, firetv, androidwear, web, tizen, tvos, webos, macos, tizenwatch, kaios, chromecast, linux, windows
│ Env Info: win32 | x64 | node v18.20.3                           │
│ Executed Time: 0h:0m:6s:791ms                                   │
│
Tizen Targets:

│ You are trying to run global rnv command in your current project.
│ This might lead to unexpected behaviour.
│ Run your rnv command with npx prefix:
│ npx rnv target list -p tizen
└─────────────────────────────────────────────────────────────────┘

C:\Users\dev\Desktop\renative\packages\template-starter>

>C:\tizen-studio\tools\emulator\bin\em-cli.bat list-vm
T-samsung-7.0-x86
W-6.5-circle-x86

works for me in windows 11
`PS D:\Projects\renative\packages\template-starter> npx rnv target list -p tizen

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ $ rnv target list -p tizen │
└─────────────────────────────────────────────────────────────────┘
info: Current platform: tizen
info: Current engine: @rnv/engine-rn-web (D:\Projects\renative\packages\template-starter\node_modules@rnv\engine-rn-web)
task: ○ target list ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
✔ Executing: "D:\Programs\tizen\tizen-studio\tools\emulator\bin\em-cli.bat" list-vm
✔ Executing: "D:\Programs\tizen\tizen-studio\tools\sdb.exe" devices
✔ Executing: "D:\Programs\tizen\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n M-7.0-x86
✔ Executing: "D:\Programs\tizen\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n T-8.0-x86
✔ Executing: "D:\Programs\tizen\tizen-studio\tools\emulator\bin\em-cli.bat" detail -n W-7.0-circle-x86
task: ✔ target list
┌─────────────────────────────────────────────────────────────────┐
│ ✔ SUMMARY | 8/14/2024, 11:44:24 AM | rnv@ │
│ $ rnv target list -p tizen │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/template-starter@1.0.0 │
│ Workspace: rnv │
│ Platform (-p): tizen │
│ Engine: @rnv/engine-rn-web │
│ App Config (-c): template │
│ Build Scheme (-s): debug │
│ Supported Platforms: ios, android, androidtv, firetv, androidwear, web, tizen, tvos, webos, macos, tizenwatch, kaios, chromecast, linux, windows
│ Env Info: win32 | x64 | node v18.18.1 │
│ Executed Time: 0h:0m:5s:677ms │
│
Tizen Targets:
[0]> T-8.0-x86

│ You are trying to run global rnv command in your current project.
│ This might lead to unexpected behaviour.
│ Run your rnv command with npx prefix:
│ npx rnv target list -p tizen
└─────────────────────────────────────────────────────────────────┘
PS D:\Projects\renative\packages\template-starter> D:\Programs\tizen\tizen-studio\tools\emulator\bin\em-cli.bat list-vm
M-7.0-x86
T-8.0-x86
W-7.0-circle-x86
PS D:\Projects\renative\packages\template-starter>

`

@Marius456 Marius456 marked this pull request as draft August 16, 2024 06:54
@justinasRm justinasRm marked this pull request as ready for review August 16, 2024 08:29
@Marius456 Marius456 added e2e and removed e2e labels Aug 19, 2024
@justinasRm justinasRm marked this pull request as draft August 20, 2024 07:01
@justinasRm justinasRm marked this pull request as ready for review August 22, 2024 07:03
@Marius456 Marius456 modified the milestones: 1.1, 1.2 Aug 26, 2024
@pauliusguzas
Copy link
Collaborator

Works on simulators as expected, devices show up on all commands

@pauliusguzas pauliusguzas self-requested a review August 27, 2024 08:15
@pauliusguzas
Copy link
Collaborator

remaining issue moved to #1666

@pauliusguzas pauliusguzas merged commit 41501e4 into main Aug 27, 2024
13 checks passed
@pauliusguzas pauliusguzas deleted the tizen-target-list branch August 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marius456 Marius456 Marius456 approved these changes

@pauliusguzas pauliusguzas pauliusguzas approved these changes

@GabrieleKaceviciute GabrieleKaceviciute GabrieleKaceviciute left review comments

Assignees

@justinasRm justinasRm

Labels
e2e
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@justinasRm @Marius456 @pauliusguzas @GabrieleKaceviciute