dep: require nokogiri >= 1.12.0 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-fix-nokogiri-dep
branch
from
d8028b1
to
fb9c46d
Compare
which in turn requires ruby >= 2.5.0, so let's be explicit about that requirement in the gemspec as well.
flavorjones
force-pushed
the
flavorjones-fix-nokogiri-dep
branch
from
fb9c46d
to
0fc8515
Compare
sl0thentr0py
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
May 15, 2023
sl0thentr0py
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
May 15, 2023
|
FYI: If you don't yank |
|
I'm not yanking these versions of the gem, as yanking tends to be more disruptive to the community. Please pin this dependency in your apps if you're on Ruby 2.4 or earlier, or consider upgrading. Apologies for the inconvenience. |
|
Fair enough. But we're on Ruby 2.7. Our OS is unable to upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266
This PR updates the Nokogiri dependency to
>= 1.12.0, and the Ruby dependency to>= 2.5.0(which matches the requirement of Nokogiri 1.12.x).