Skip to content

Commit

Permalink
Build Exiv2 without libinih.
Browse files Browse the repository at this point in the history
Recently, Exiv2 removed some files from their tree to make it a proper
dependency: Exiv2/exiv2#2443

Though a comment in this MR seems to say it should be a hard dependency,
this other patch says it only disable readExiv2Config() which makes
Exiv2 not read custom user config files: Exiv2/exiv2#2465
(also verified by grepping EXV_ENABLE_INIH which indeed shows it is only
used by this one function)

I assume this is the config file which is discussed of:
https://exiv2.org/manpage.html#config_file

For GIMP, I am unsure if this custom optional config file is that
important and if anyone actually makes use of this. Even more in the
flatpak, where eventually the access to $HOME (where the user file would
be) is meant to disappear for sandboxing reasons. So instead of adding
this additional dep, let's just disable the user config file feature.
  • Loading branch information
Jehan committed Jun 7, 2023
1 parent 6209a38 commit 4335a09
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion org.gimp.GIMP.json
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@
"name": "exiv2",
"buildsystem": "cmake-ninja",
"config-opts": [
"-DEXIV2_ENABLE_BMFF=ON"
"-DEXIV2_ENABLE_BMFF=ON",
"-DEXIV2_ENABLE_INIH=OFF"
],
"builddir": true,
"cleanup": [
Expand Down

0 comments on commit 4335a09

Please sign in to comment.