Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the kube-flannel.yaml in order to work #518

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Sep 25, 2016

@tomdee This makes it possible to run this flannel daemonset on other architectures as well, thanks!
Just curl -sSL <url> | sed "s/amd64/arm/" | kubectl apply -f - and you're done!

Can you merge this please so we can use it with kubeadm please?

@tomdee
Copy link
Contributor

tomdee commented Sep 26, 2016

@luxas I was trying to avoid the situation where external projects rely on this "sample" config file. I don't believe that the flannel project is the right place for the canonical version of this file. See my comments #483 (comment) and #483 (comment)

@@ -18,7 +18,7 @@ data:
}
net-conf.json: |
{
"Network": "10.244.0.0/16",
"Network": "10.2.0.0/16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for?

image: busybox
command: [ "/bin/sh", "-c", "set -e -x; TMP=/etc/cni/net.d/.tmp-flannel-cfg; cp /etc/kube-flannel/cni-conf.json ${TMP}; mv ${TMP} /etc/cni/net.d/10-flannel.conf; while :; do sleep 3600; done" ]
image: quay.io/coreos/flannel-git:v0.6.1-28-g5dde68d-amd64
command: [ "/bin/sh", "-c", "set -e -x; cp -f /etc/kube-flannel/cni-conf.json /etc/cni/net.d/10-flannel.conf; while true; do sleep 3600; done" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for?

@luxas
Copy link
Contributor Author

luxas commented Oct 1, 2016

Okay, the only thing I want here is that this manifest will be multiarch, so I can easily can run kubectl apply on it.

Please merge this as soon as possible. I removed the strange parts from this PR now

If you want to create a separate project for kubeadm integration, feel free to.
If you do, it would be the same as weave has done, but a separate directory of the flannel project is also fine for me.

At least, please merge and I'll add this to http://kubernetes.io/docs/admin/addons/, it will be good for users.

@luxas
Copy link
Contributor Author

luxas commented Oct 14, 2016

ping @tomdee

@tomdee
Copy link
Contributor

tomdee commented Oct 25, 2016

@luxas I still don't really understand this change. Do you need the version pinning stuff or just the extra label?

@luxas
Copy link
Contributor Author

luxas commented Oct 25, 2016

a) We need somewhere to point users to regarding flannel and kubeadm
b) The manifest has to point to a specific -ARCH tag (-amd64 by default) in order to be able to sed it to arm or arm64 easily

See kubernetes/kubernetes#30356 for reference

Thanks, and please let this though!

@tomdee tomdee merged commit 8f21bbd into flannel-io:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants