Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations to the helm chart #1907

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

manuelbuil
Copy link
Collaborator

@manuelbuil manuelbuil commented Mar 15, 2024

Description

Flannel might deploy in clusters whose nodes contain taints and thus we need the tolerations field to be configurable

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil changed the title Fix the helm chart and add tolerations Add tolerations to the helm chart Mar 15, 2024
@manuelbuil manuelbuil merged commit 572a4f7 into flannel-io:master Mar 15, 2024
8 checks passed
@manuelbuil manuelbuil deleted the flannelTolerations branch March 15, 2024 18:27
@fungaren
Copy link

This commit introduced a bug that not all taints are tolerated, at least the default taint for master node node-role.kubernetes.io/master:NoSchedule is not tolerated.

Please be careful if you are changing the behavior.

@brandond
Copy link

brandond commented Mar 25, 2024

@fungaren the node-role.kubernetes.io/master label has been deprecated for quite some time, in favor of control-plane. In what environment do you still see this taint being set?

@fungaren
Copy link

@brandond I have an old Kubernetes cluster which is using 1.24. While upgrading flannel version the problem appeared. Now I have decide to add --set flannel.tolerations[0].effect=NoSchedule to address it.

Maybe it should not be considered as a bug, but it is indeed a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants