Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in chart config template #1862

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

manuelbuil
Copy link
Collaborator

Description

When installing flannel from the chart, if we don't quote that value, we get the error:

E0124 10:50:40.343650       1 main.go:226] Failed to create SubnetManager: error parsing subnet config: invalid character 'A' after object key:value pair

Because the config is:

  net-conf.json: |
    {
      "Network": "10.42.0.0/16",
      "Backend": {
        "VNI": 1,
        "MTU": 1500,
        "MacPrefix": 0E-2A,
        "Type": "vxlan"
      }
    }

i.e. the MacPrefix requires quotes

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix bug in chart config template

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil merged commit 7cc16e2 into flannel-io:master Feb 7, 2024
8 checks passed
@manuelbuil manuelbuil deleted the fixChart branch February 7, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants