Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the VNI to the error message in Windows #1839

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

manuelbuil
Copy link
Collaborator

Description

There is a log that complains about the VNI not being 4096 but it does not specify what is the value. This PR adds that information to the log line

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@@ -103,7 +103,7 @@ func (nw *network) handleSubnetEvents(batch []lease.Event) {
}

if vxlanAttrs.VNI < 4096 {
log.Error("VNI is required to greater than or equal to 4096 on Windows.")
log.Errorf("VNI is %d but it is required to greater than or equal to 4096 on Windows.", vxlanAttrs.VNI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: it is required to be greater

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! I copied/pasted the error

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil merged commit 766596d into flannel-io:master Dec 19, 2023
8 checks passed
@manuelbuil manuelbuil deleted the flannelWin branch December 19, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants