Profile by pid #53
Merged
Profile by pid #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks like a reasonable addition! I think it would be good if the CLI tool would raise an error if |
|
Sounds good. The CLI now checks that trailing_arguments is empty before generating the Workload for the pid. |
jonas-schievink
approved these changes
Nov 30, 2019
leod
pushed a commit
to leod/flamegraph
that referenced
this pull request
Jun 3, 2023
Profile by pid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is preferable to be able to profile a running process instead of needing to restart the process under the profiler. This PR adds a
Workloadenum which can contain a command or a pid. Additionally a flag for passing in a pid instead of a command is provided for theflamegraphbinary.Usage:
These changes do not break the existing cli interface.