remove konoha from requirements.txt #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @marctorsoc, thanks for the PR! The tests are failing since we test for Japanese tokenization. That test would need to be removed. You should also run black formatting (see here) to pass the checks. |
|
@alanakbik this should be fixed now, I think |
|
@marctorsoc thanks for fixing this! |
For what I see in https://github.com/flairNLP/flair/blob/master/.github/workflows/ci.yml, there's no automatic release. Could you release a new version after this? Do you plan to add auto-release when a PR is merged to master, or you prefer to keep manual like now? |
|
We'll try to release a new version soon, and after that switch to more frequent updates! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.