Call super().__setstate__() in Embeddings
#3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a model that was trained with an older torch version, it is possible that an
AttributeErroroccurs. This can happen if new attributes were added totorch.nn.Module.For backwards compatibility, they implemented their
__setstate__to add these attributes if they are not present (https://github.com/pytorch/pytorch/blob/ae4ec7de1e6f60aa7dcf4d5187c720f2f40543c3/torch/nn/modules/module.py#L1564).In oder to be independent from these changes and increase backwards compatibility, it would be good, if the super-method would be called when unpickling Embeddings instead of setting
__dict__.