Refactor Token and Sentence Positional Properties #3001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Token and Sentence positional properties inherited from the DataPoint to replace the
self.start_pos
andself.end_pos
attributes.For the Sentence, both variants of accessing positional information behaved differently, resulting in inconsistent results where they appropriately should have been aliases. These are the inconsistencies:
Initializing the Sentence with
str
, i.e. untokenized input.start_position
in the init but this is not respected in thestart_position
property. It always returns zero. The inconsistency is also that instart_pos
the start position offset is included.Suggestion: Only use and expose the property inherited from the DataPoint. Having multiple attributes doing the same thing with different names may get confusing.
Initializing the Sentence with
List[str]
, i.e. pre-tokenized input.end_pos
andend_position
actually do not behave the same.len(s)
.List[str]
to the case of initializing thestr
.Please see the commits as isolated corresponding to the suggestions.