Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hf-hub version #2837

Merged

Conversation

helpmefindaname
Copy link
Collaborator

@helpmefindaname helpmefindaname commented Jun 24, 2022

The newest release of the huggingface hub releases a new way of downloading models with additional features such as lazy loading and git-aware cache file layouting.

I suppose there is no good reason to use older versions, so I added a pin of the version to force upgrades

@helpmefindaname
Copy link
Collaborator Author

Notice: the tests fail due to the error addressed in #2827 but if that PR will be merged, master will still fail due to the hf-hub upgrade.
Both this PR and #2827 need to be merged to make the master branch green again.

@alanakbik alanakbik merged commit 2fe9fdc into flairNLP:master Jun 28, 2022
@alanakbik
Copy link
Collaborator

@helpmefindaname thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants